Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Community Drive Functionality #383

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Delete Community Drive Functionality #383

merged 4 commits into from
Dec 4, 2024

Conversation

maxgrove42
Copy link
Collaborator

@maxgrove42 maxgrove42 commented Dec 4, 2024 •
edited
Loading

#382

Description

  • Implements functionality to delete (aka inactivate) a community drive
  • Sets all pledges to 0
  • Sets drive to inactive

Change Type (delete non-relevant options)

  • 💡 New feature (non-breaking change which adds functionality)

@maxgrove42 maxgrove42 self-assigned this Dec 4, 2024
@maxgrove42 maxgrove42 added this to the Sprint 12 milestone Dec 4, 2024
@maxgrove42 maxgrove42 linked an issue Dec 4, 2024 that may be closed by this pull request
Delete Community Drive #382
Closed
@coveralls
Copy link

coveralls commented Dec 4, 2024 •
edited
Loading

Coverage Status

coverage: 91.083% (+0.5%) from 90.579%
when pulling 7b74cf3 on feature/issue-382/delete-community-drive
into bbaea71 on develop.

@maxgrove42 maxgrove42 marked this pull request as ready for review December 4, 2024 04:19
QahtanAlJammali
QahtanAlJammali approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@QahtanAlJammali QahtanAlJammali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, darn Black requires to reformat one file, but otherwise looking great! Thanks Max!

@QahtanAlJammali
Copy link
Collaborator

seems to be failing one of the tests written for it

@maxgrove42
Copy link
Collaborator Author

@QahtanAlJammali I wonder if the linting changed something. In this build, everything passed. https://app.travis-ci.com/github/gcivil-nyu-org/wed-fall24-team5/jobs/628700330

@maxgrove42
Copy link
Collaborator Author

@QahtanAlJammali ah yes. one of the linting requirements was no blank EXCEPTs and i updated one of the error messages. Quick and easy fix.

@maxgrove42
Copy link
Collaborator Author

@QahtanAlJammali updated test!

@QahtanAlJammali
Copy link
Collaborator

Sweet! time to squash and merge! 🙌

@QahtanAlJammali QahtanAlJammali merged commit c705f02 into develop Dec 4, 2024
3 checks passed
@maxgrove42 maxgrove42 deleted the feature/issue-382/delete-community-drive branch December 8, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QahtanAlJammali QahtanAlJammali QahtanAlJammali approved these changes

@estchang estchang Awaiting requested review from estchang

@TekuriSaiAkhil TekuriSaiAkhil Awaiting requested review from TekuriSaiAkhil

@arsalananwar11 arsalananwar11 Awaiting requested review from arsalananwar11

Assignees

@maxgrove42 maxgrove42

Labels
None yet
Projects
None yet
Milestone
Sprint 12
Development

Successfully merging this pull request may close these issues.

Delete Community Drive
3 participants
@maxgrove42 @coveralls @QahtanAlJammali