[Uptime] handle null duration on ping list (elastic#125438)

* uptime - handle null duration * adjust types * Update x-pack/plugins/uptime/server/lib/synthetics_service/service_api_client.ts * raise per page of synthetics monitors * Remove tooltip
gchaps · Feb 14, 2022 · 52e9c51 · 52e9c51
1 parent d364f23
commit 52e9c51
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 9 deletions.
diff --git a/x-pack/plugins/uptime/common/runtime_types/ping/ping.ts b/x-pack/plugins/uptime/common/runtime_types/ping/ping.ts
@@ -90,14 +90,14 @@ export type Tls = t.TypeOf<typeof TlsType>;
 
 export const MonitorType = t.intersection([
   t.type({
-    duration: t.type({
-      us: t.number,
-    }),
     id: t.string,
     status: t.string,
     type: t.string,
   }),
   t.partial({
+    duration: t.type({
+      us: t.number,
+    }),
     check_group: t.string,
     ip: t.string,
     name: t.string,

diff --git a/x-pack/plugins/uptime/public/components/monitor/ping_list/ping_list.test.tsx b/x-pack/plugins/uptime/public/components/monitor/ping_list/ping_list.test.tsx
@@ -42,7 +42,6 @@ describe('PingList component', () => {
         type: 'io',
       },
       monitor: {
-        duration: { us: 1370 },
         id: 'auto-tcp-0X81440A68E839814D',
         ip: '255.255.255.0',
         name: '',
@@ -161,9 +160,6 @@ describe('PingList component', () => {
                 "type": "io",
               },
               "monitor": Object {
-                "duration": Object {
-                  "us": 1370,
-                },
                 "id": "auto-tcp-0X81440A68E839814D",
                 "ip": "255.255.255.0",
                 "name": "",
@@ -186,6 +182,13 @@ describe('PingList component', () => {
       });
     });
 
+    describe('duration column', () => {
+      it('shows -- when duration is null', () => {
+        const { getByTestId } = render(<PingList />);
+        expect(getByTestId('ping-list-duration-unavailable-tool-tip')).toBeInTheDocument();
+      });
+    });
+
     describe('formatDuration', () => {
       it('returns zero for < 1 millisecond', () => {
         expect(formatDuration(984)).toBe('0 ms');

diff --git a/x-pack/plugins/uptime/public/components/monitor/ping_list/ping_list_table.tsx b/x-pack/plugins/uptime/public/components/monitor/ping_list/ping_list_table.tsx
@@ -140,7 +140,12 @@ export function PingListTable({ loading, error, pings, pagination, onChange, fai
       name: i18n.translate('xpack.uptime.pingList.durationMsColumnLabel', {
         defaultMessage: 'Duration',
       }),
-      render: (duration: number) => formatDuration(duration),
+      render: (duration: number | null) =>
+        duration ? (
+          formatDuration(duration)
+        ) : (
+          <span data-test-subj="ping-list-duration-unavailable-tool-tip">{'--'}</span>
+        ),
     },
     ...(hasError
       ? [

diff --git a/x-pack/plugins/uptime/public/components/overview/monitor_list/monitor_list.tsx b/x-pack/plugins/uptime/public/components/overview/monitor_list/monitor_list.tsx
@@ -135,7 +135,7 @@ export const MonitorListComponent: ({
               timestamp={timestamp}
               summaryPings={summaryPings ?? []}
               monitorType={type}
-              duration={duration!.us}
+              duration={duration?.us}
               monitorId={monitorId}
             />
           );

diff --git a/x-pack/plugins/uptime/server/lib/synthetics_service/synthetics_service.ts b/x-pack/plugins/uptime/server/lib/synthetics_service/synthetics_service.ts
@@ -280,6 +280,7 @@ export class SyntheticsService {
     const findResult = await savedObjectsClient.find<SyntheticsMonitor>({
       type: syntheticsMonitorType,
       namespaces: ['*'],
+      perPage: 10000,
     });
 
     hydrateSavedObjects({