-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top VI Filtering #21
Top VI Filtering #21
Conversation
Added "get" to the option to read what the Top Level VI is.
Added "get" to the acceptable items in the dialog.
Resolved gcentral#16. Resolved gcentral#20.
@crossrulz The rest of the code good, but I have a couple of additional comments related to the process (congrats on being the guinea pig):
Again, thanks for being the test subject on this. Feel free to reach out if any of this wasn't clear. |
|
@crossrulz In this example, I renamed 'main' in your fork to 'crossrulz-main', but you can see that the histories of those two branches can't easily be synched since their commit histories can't be made to match (without more merging). |
I think the issue you are seeing is the crossrulz-main is currently linked to origin/main. I think I have a fix for this on my side (created a Develop branch that is directly linked to origin/develop). You'll see this when I update the PR after giving people a chance to try out the update due to the issue you found in #20. |
In order to clean up the branch history, I need to close this PR. I will then create another one using a branch that is directly forked from the Develop branch. |
Resubmitted as #23 using a branch forked from the Develop branch |
Resolved #16 - Only a VI or VIT that is "Standard" can be set to as the Top Level
Resolved #20 - The project owning the VI that Quick Drop is launched from is used instead of the application active project
Resolved #18 - Added "get" as an acceptable input to read the Top Level VI path
Resolved #19 - Added "get" to list of acceptable commands with an invalid input