Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import polyfit/val from numpy #207

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

TheSkyentist
Copy link
Contributor

Import polyval from numpy instead of scipy to fix mitigate issues.

@gbrammer
Copy link
Owner

I think it would be safest to

from numpy.polynomial.polynomial import polyfit, polyval

rather than from the general numpy namespace with from numpy import polyfit, polyval.

@TheSkyentist
Copy link
Contributor Author

Good idea, I've committed the requested changes.

@gbrammer gbrammer merged commit 0d9b5cd into gbrammer:master Feb 16, 2024
9 checks passed
@gbrammer
Copy link
Owner

Thanks!

@TheSkyentist TheSkyentist deleted the no-scipy-poly branch February 29, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants