Use setAttribute instead of setAttributeNode #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some versions of IE setAttributeNode throws the enigmatic "Member not found" error with particular combinations of element and attribute. For example calling setAttributeNode on a td with a colspan attr. Go figure :) I’m not sure why sanitize uses setAttributeNode but setAttribute doesn’t seem to do any harm, so here we are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By author (5 years ago):
In some versions of IE setAttributeNode throws the enigmatic "Member not
found" error with particular combinations of element and attribute. For
example calling setAttributeNode on a td with a colspan attr. Go figure :)
I’m not sure why sanitize uses setAttributeNode but setAttribute doesn’t
seem to do any harm, so here we are.
Update:
We have been using this fork for years now, and it seems to do little harm. Might as well send this PR so we can clean up!