-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added simple and ugly completion script for rgbasm #895
Conversation
contrib/bash_compl/_rgbasm.bash
Outdated
# using *.z80 -> if no .z80 files are found it uses literal "*.z80" | ||
# using ./*.z80 would show options starting with an ugly ./ | ||
# this is a hard decision... maybe use sed to filter ./*? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# using *.z80 -> if no .z80 files are found it uses literal "*.z80" | |
# using ./*.z80 would show options starting with an ugly ./ | |
# this is a hard decision... maybe use sed to filter ./*? |
(This comment appears outdated, since the above line does use sed -E "s_^./__
.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to say "this is an ugly solution. but alternatives are equally ugly" you can remove it if you think it doesn't matter
Thanks for the contribution, DaKnig! I'm noticing a few bugs (for example, Also, tabbing The script also tabs I gave a read to the documentation you linked and what that linked to, and I believe I now have a more solid understanding of how Bash completions work; thanks for that! I think that bugs can be fixed and some features improved by using builtins more (mainly |
I was comparing against other native Unix tools completion with bash. IMO the stacked short opt completion is not necessary, a user should be able to just make many one letter opts. not just for consistency with behavior with some other programs but also for simplicity of the script. I think the time I had allocated for this project is over, and I can't stand coding in bash for much longer, so I won't be able to finish the job... maybe we can do this in C? or is maintaining C a hassle? maybe launching C just for this would be extremely slow? maybe python can do this better.. I am not sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now the code inside the body of the if statement doesn't have one indentation over what the if has
80a98d7
to
75f6dfc
Compare
Rewrote the script to fix the whitespace bugs, and more properly parse the command-line! Hopefully that'll do better. |
d0fa0fd
to
2509aa9
Compare
Should have large feature parity with the Zsh completion Co-authored-by: DaKnig <[email protected]>
2509aa9
to
4efdbe4
Compare
4efdbe4
to
0b40012
Compare
No description provided.