Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul "Install" instructions #48

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Overhaul "Install" instructions #48

merged 5 commits into from
Oct 11, 2023

Conversation

avivace
Copy link
Member

@avivace avivace commented Jul 2, 2023

I wasn't quick enough to review #47, so let me try again.

The install page suffers from a lot of problems right now, making the whole thing unreadable and inaccessible to the average target of "new users of RGBDS".

Let's try to review the criteria:

  • Keep the details to the minimum. We are not interesting on explaining the intricacies of installing on Windows or in which way different ways of installing on Windows are related.
  • Our primary dev environment (and the largest RGBDS user quota) target is "Linux". We have pre-built binaries for amd64 on the CI (?). Until we start packaging it for main distributions, that should be the primary suggested way to obtain the binaries. End of the story.
  • Reading the install page is incredibly complex right now and leads to so many choices that it makes me want to give up just looking at all the branches and choices I have to make.

Feel free to discuss any of these points. In the meantime, I started an overhaul:

  • Removed mention of rgbds2 package. Why would someone be interested in it? It will just make the explanation and the options more complex for new users. If I need an old version, I'll look up for an old release, no need to imply 3 choices in the Arch Linux tab. it's not an alternative/LTS branch receiving updates, so it's not like I need to subscribe to a rgbds2 package.
  • Made a generic "Linux" tab as the default. Go to releases, pick a pre-built binary for the arch you need. You're done.

Fixes #51.

@ISSOtm
Copy link
Member

ISSOtm commented Jul 2, 2023

Are you sure the largest portion of our user base is on Linux? Lacking any better info (people will get mad if we add any telemetry), I've been referencing the Sublime Text extension's stats, which are approximately 50% Windows, 25% macOS, 25% Linux.
[EDIT] Since Sublime is non-free software, and not in any distro's default repos, maybe the Linux share is biased downwards. IDRK.

As far as I'm aware, distributing raw Linux binaries is a bad idea because they'll be incompatible across distributions? I will look up info on that.

@avivace
Copy link
Member Author

avivace commented Jul 20, 2023

Let's also remember to mention rgbenv

@avivace
Copy link
Member Author

avivace commented Aug 27, 2023

This is currently blocked by gbdev/rgbds#1148 not being applied to old releases, so we don't have the Linux build until we release

@avivace
Copy link
Member Author

avivace commented Sep 14, 2023

#51 could also be fixed here

@ISSOtm
Copy link
Member

ISSOtm commented Sep 15, 2023

I'm not sure Docker would be much use for installing RGBDS?

src/pages/install/index.md Outdated Show resolved Hide resolved

:::
The install instructions change a bit depending on the environment you wish to use RGBDS with.

<details>
<summary>"Plain" Windows (CMD, PowerShell)</summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the WSL instructions should instruct to refer to the Linux instructions for the corresponding Linux distribution (noting that if you don't know, it's probably Ubuntu).

I'm thinking we should organise the tabs something like WSL, then MSYS2 or Cygwin, and finally none of these. That should make what the last one is about, clearer. I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a good idea, although I have no experience whatsoever on Windows so if you have any specific ideas on how to reorganize the Windows tab feel free to push

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a Windows user anymore, but I think I have some ideas. I'll do that then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done!

src/pages/install/index.md Outdated Show resolved Hide resolved
@avivace avivace marked this pull request as draft September 19, 2023 20:21
@avivace avivace force-pushed the install-overhaul-fixes branch from 9f87a70 to 5ea3211 Compare September 24, 2023 19:31
@avivace avivace changed the title Improve Install documentation Overhaul "Install" instructions Sep 25, 2023
@avivace avivace added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 25, 2023
@avivace avivace marked this pull request as ready for review September 25, 2023 23:10
@avivace avivace requested a review from ISSOtm September 25, 2023 23:10
@pinobatch
Copy link
Member

It has been suggested to use https://nightly.link/ to solve the lack of guest downloads for master.

@avivace
Copy link
Member Author

avivace commented Sep 27, 2023

@ISSOtm

I'm not sure Docker would be much use for installing RGBDS?

The container image provides a very quick way, literally a oneliner (if you have a container runtime installer ofc) to obtain a linux environment able to run AND build RGBDS (the version you're checking out, but potentially any other).

It may also be useful as a "base" image for pipelines.

Anyway, we'll have some stats in a while on how popular/really used really is, so I'm okay in removing it from the options if it we understand is not really used..


Another thing, are we really sure we want the Tabs navigation here? Now the instructions were slimmed down, they seem to amount just 4-5 lines per platform so I'm now sure if requiring additional clicks is really useful?


@pinobatch where should the nightly link https://nightly.link/gbdev/rgbds/workflows/testing/master go? In the "Install master?" (https://rgbds.gbdev.io/install/master) (which could also be renamed to "Canary" tbf, it's clearer

Comment on lines +9 to 10
Below is a list of Operative Systems for which pre-built executables are available. If none of these options fits your needs, you can [build from source](/install/source).

Copy link
Member

@ISSOtm ISSOtm Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Below is a list of Operative Systems for which pre-built executables are available. If none of these options fits your needs, you can [build from source](/install/source).
Below is a list of OSes for which pre-built executables are available.
If none of these options fits your needs, you can [build from source](/install/source).

We can use <abbr title="Operating Systems"> to explain "OSes" instead, if desired.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree!

The install instructions change a bit depending on the environment you wish to use RGBDS with.
Linux x86_64 ready binaries are available in our [Releases](https://github.com/gbdev/rgbds/releases) page.

##### Arch
Copy link
Member

@ISSOtm ISSOtm Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
##### Arch
### Arch

We're only at heading level 2 here; but level 3 seems appropriate too.

```bash
pacman -S rgbds
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change


:::
The install instructions change a bit depending on the environment you wish to use RGBDS with.

<details>
<summary>"Plain" Windows (CMD, PowerShell)</summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a Windows user anymore, but I think I have some ideas. I'll do that then.

@avivace avivace merged commit 89cdda3 into master Oct 11, 2023
@avivace avivace deleted the install-overhaul-fixes branch October 31, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention the rgbds docker image
3 participants