-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul "Install" instructions #48
Conversation
Are you sure the largest portion of our user base is on Linux? Lacking any better info (people will get mad if we add any telemetry), I've been referencing the Sublime Text extension's stats, which are approximately 50% Windows, 25% macOS, 25% Linux. As far as I'm aware, distributing raw Linux binaries is a bad idea because they'll be incompatible across distributions? I will look up info on that. |
Let's also remember to mention rgbenv |
This is currently blocked by gbdev/rgbds#1148 not being applied to old releases, so we don't have the Linux build until we release |
#51 could also be fixed here |
I'm not sure Docker would be much use for installing RGBDS? |
src/pages/install/index.md
Outdated
|
||
::: | ||
The install instructions change a bit depending on the environment you wish to use RGBDS with. | ||
|
||
<details> | ||
<summary>"Plain" Windows (CMD, PowerShell)</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the WSL instructions should instruct to refer to the Linux instructions for the corresponding Linux distribution (noting that if you don't know, it's probably Ubuntu).
I'm thinking we should organise the tabs something like WSL
, then MSYS2 or Cygwin
, and finally none of these
. That should make what the last one is about, clearer. I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a good idea, although I have no experience whatsoever on Windows so if you have any specific ideas on how to reorganize the Windows tab feel free to push
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a Windows user anymore, but I think I have some ideas. I'll do that then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, done!
9f87a70
to
5ea3211
Compare
It has been suggested to use https://nightly.link/ to solve the lack of guest downloads for |
The container image provides a very quick way, literally a oneliner (if you have a container runtime installer ofc) to obtain a linux environment able to run AND build RGBDS (the version you're checking out, but potentially any other). It may also be useful as a "base" image for pipelines. Anyway, we'll have some stats in a while on how popular/really used really is, so I'm okay in removing it from the options if it we understand is not really used.. Another thing, are we really sure we want the Tabs navigation here? Now the instructions were slimmed down, they seem to amount just 4-5 lines per platform so I'm now sure if requiring additional clicks is really useful? @pinobatch where should the nightly link https://nightly.link/gbdev/rgbds/workflows/testing/master go? In the "Install master?" (https://rgbds.gbdev.io/install/master) (which could also be renamed to "Canary" tbf, it's clearer |
Below is a list of Operative Systems for which pre-built executables are available. If none of these options fits your needs, you can [build from source](/install/source). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below is a list of Operative Systems for which pre-built executables are available. If none of these options fits your needs, you can [build from source](/install/source). | |
Below is a list of OSes for which pre-built executables are available. | |
If none of these options fits your needs, you can [build from source](/install/source). |
We can use <abbr title="Operating Systems">
to explain "OSes" instead, if desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree!
The install instructions change a bit depending on the environment you wish to use RGBDS with. | ||
Linux x86_64 ready binaries are available in our [Releases](https://github.com/gbdev/rgbds/releases) page. | ||
|
||
##### Arch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
##### Arch | |
### Arch |
We're only at heading level 2 here; but level 3 seems appropriate too.
```bash | ||
pacman -S rgbds | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/pages/install/index.md
Outdated
|
||
::: | ||
The install instructions change a bit depending on the environment you wish to use RGBDS with. | ||
|
||
<details> | ||
<summary>"Plain" Windows (CMD, PowerShell)</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a Windows user anymore, but I think I have some ideas. I'll do that then.
I wasn't quick enough to review #47, so let me try again.
The install page suffers from a lot of problems right now, making the whole thing unreadable and inaccessible to the average target of "new users of RGBDS".
Let's try to review the criteria:
Feel free to discuss any of these points. In the meantime, I started an overhaul:
Fixes #51.