client: AppendService owns its buffer sync.Pool #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using a global singleton Pool.
In the future this may allow for better coupling of resource quotas
and back-pressure against specific AppendService instances,
correlated to different consumer.Shards.
The immediate motivation is fixing a test-only bug, where a
mockFile{} fixture is added to the global Pool and causes a
future test case to fail.
Issue #297
psFried
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Looks good to me. One thought that occurs is that the lifecycle of each pool is now potentially a lot shorter. Is there anything we should be doing to cleanup the pools when an append service is shutdown, or is it ok to let it be handled by the garbage collector?
|
A-ok for the garbage collector to deal with them. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using a global singleton Pool.
In the future this may allow for better coupling of resource quotas
and back-pressure against specific AppendService instances,
correlated to different consumer.Shards.
The immediate motivation is fixing a test-only bug, where a
mockFile{} fixture is added to the global Pool and causes a
future test case to fail.
Issue #297
This change is