Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test flake: TestGracefulStopTimeout #301

Closed
jgraettinger opened this issue Sep 15, 2021 · 1 comment
Closed

test flake: TestGracefulStopTimeout #301

jgraettinger opened this issue Sep 15, 2021 · 1 comment
Assignees
@jgraettinger
Labels
bug

Comments

@jgraettinger
Copy link
Contributor

This is flaking because the test is racing (and losing) a 25ms read deadline of the underlying connection.
@jgraettinger jgraettinger self-assigned this Sep 15, 2021
jgraettinger added a commit that referenced this issue Sep 15, 2021
@jgraettinger
brokertest: fix graceful stop test flake
46cab3f 
GracefulStopTimeout can't be shrunk until after all connection setup has
occurred, as it's otherwise racing cmux matching of a mux for
newly-opened test connections.

Issue #301
@jgraettinger jgraettinger mentioned this issue Sep 15, 2021
Merged
@jgraettinger
Copy link
Contributor Author

Another (unrelated) test flake I'm tackling with this:

time="2021-09-15T20:45:51Z" level=warning msg="served Append RPC failed" client="127.0.0.1:44628" err="append stream: unexpected EOF" req="journal:\"a/journal\" "
time="2021-09-15T20:45:51Z" level=info msg="stopping local journal replica" name=a/journal
--- FAIL: TestAppendBadlyBehavedClientCases (0.09s)
    append_api_test.go:168: 
        	Error Trace:	append_api_test.go:168
        	Error:      	Error message not equal:
        	            	expected: "rpc error: code = Canceled desc = context canceled"
        	            	actual  : "rpc error: code = Unknown desc = append stream: unexpected EOF"
        	Test:       	TestAppendBadlyBehavedClientCases
FAIL

The actual error is returned by appendFSM on reading an EOF from the stream, where an explicit empty AppendRequest was expected. That a client context cancellation became a server EOF is ... not great. And may be a recent gRPC regression (?) but isn't a problem from a correctness standpoint.

jgraettinger added a commit that referenced this issue Sep 15, 2021
@jgraettinger
broker: test flake from cancellation being read as server EOF
69eb682 
Update expectation to include alternative (valid) error that can be
read.

Issue #301
jgraettinger added a commit that referenced this issue Sep 16, 2021
@jgraettinger
brokertest: fix graceful stop test flake
96c65c9 
GracefulStopTimeout can't be shrunk until after all connection setup has
occurred, as it's otherwise racing cmux matching of a mux for
newly-opened test connections.

Issue #301
jgraettinger added a commit that referenced this issue Sep 16, 2021
@jgraettinger
broker: test flake from cancellation being read as server EOF
11233c8 
Update expectation to include alternative (valid) error that can be
read.

Issue #301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgraettinger jgraettinger

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgraettinger