Backport cmake/test fixes to sdf6 #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <[email protected]>
* Also use python3 in test Signed-off-by: Steve Peters <[email protected]>
chapulina
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
The changes look good to me. The homebrew warning is already present on sdf6:
https://build.osrfoundation.org/job/sdformat-ci-sdformat6-homebrew-amd64/35/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes issues on
sdf6branch when built on Ubuntu 20.04, as exposed by testing for gazebo-tooling/release-tools#565 and backports terminology fixes in ChangelogSummary
There is a cmake warning and test failure when building
sdf6on Ubuntu 20.04:These have already been fixed in later versions of
libsdformat:https://github.com/ignitionrobotics/sdformat/pull/328test failure was fixed in Find python3 in cmake, fix warning #328Value of sdf_headers contained a newlinecmake warning was fixed by 0c972bd that was squashed in Don't install deprecated parser_urdf.hh header #276Also, I back ported the use of
libsdformatandSDFormatin the ChangelogChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge