Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Joint DOM to Element #759

Merged
merged 7 commits into from
Nov 23, 2021
Merged

Convert Joint DOM to Element #759

merged 7 commits into from
Nov 23, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Nov 20, 2021

Signed-off-by: Ian Chen [email protected]

🎉 New feature

Summary

Adds ToElement() function to convert Joint and JointAxis DOM to sdf::ElementPtr

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2021

Codecov Report

Merging #759 (c6d1ab7) into sensor_to_element (2ed0597) will decrease coverage by 0.14%.
The diff coverage is 68.88%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           sensor_to_element     #759      +/-   ##
=====================================================
- Coverage              88.66%   88.52%   -0.15%     
=====================================================
  Files                     76       76              
  Lines                  11826    11916      +90     
=====================================================
+ Hits                   10486    10549      +63     
- Misses                  1340     1367      +27     
Impacted Files Coverage Δ
src/Joint.cc 87.77% <59.01%> (-9.85%) ⬇️
src/JointAxis.cc 95.51% <89.65%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed0597...c6d1ab7. Read the comment docs.

Signed-off-by: Ian Chen <[email protected]>
Base automatically changed from sensor_to_element to sdf12 November 23, 2021 00:33
@nkoenig nkoenig merged commit e82c057 into sdf12 Nov 23, 2021
@nkoenig nkoenig deleted the joint_to_element branch November 23, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants