-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdf 1.8: add capsule geometry type #389
Merged
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e1846db
Add capsule type to sdf/1.8/geometry.sdf
scpeters febd668
Add Capsule DOM class based on Cylinder
scpeters a5d381c
Require ignition-math6 6.7
scpeters b00ed0b
Fix copyright dates
scpeters d0a8dd5
Bump enum value since HEIGHTMAP will be 6
scpeters a1ca323
Merge branch 'master' into capsule
scpeters c183dcc
Merge branch 'master' into capsule
scpeters 861a346
Fix error messages about default radius
scpeters 09f0658
Test shapes files with `ign sdf --check`
scpeters feb90f6
Simplify copy constructor
scpeters 778e3fb
Update Migration guide for capsule
scpeters 1c09156
Make ~Capsule non-virtual
scpeters 6169fec
Don't check for missing required elements
scpeters d9f11c4
Merge branch 'master' into capsule
scpeters File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ set (headers | |
Atmosphere.hh | ||
Box.hh | ||
Camera.hh | ||
Capsule.hh | ||
Collision.hh | ||
Console.hh | ||
Cylinder.hh | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,105 @@ | ||
/* | ||
* Copyright 2020 Open Source Robotics Foundation | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
*/ | ||
#ifndef SDF_CAPSULE_HH_ | ||
#define SDF_CAPSULE_HH_ | ||
|
||
#include <ignition/math/Capsule.hh> | ||
#include <sdf/Error.hh> | ||
#include <sdf/Element.hh> | ||
#include <sdf/sdf_config.h> | ||
|
||
namespace sdf | ||
{ | ||
// Inline bracket to help doxygen filtering. | ||
inline namespace SDF_VERSION_NAMESPACE { | ||
// | ||
|
||
// Forward declare private data class. | ||
class CapsulePrivate; | ||
|
||
/// \brief Capsule represents a capsule shape, and is usually accessed | ||
/// through a Geometry. | ||
class SDFORMAT_VISIBLE Capsule | ||
{ | ||
/// \brief Constructor | ||
public: Capsule(); | ||
|
||
/// \brief Copy constructor | ||
/// \param[in] _capsule Capsule to copy. | ||
public: Capsule(const Capsule &_capsule); | ||
|
||
/// \brief Move constructor | ||
/// \param[in] _capsule Capsule to move. | ||
public: Capsule(Capsule &&_capsule) noexcept; | ||
|
||
/// \brief Destructor | ||
public: virtual ~Capsule(); | ||
|
||
/// \brief Move assignment operator. | ||
/// \param[in] _capsule Capsule to move. | ||
/// \return Reference to this. | ||
public: Capsule &operator=(Capsule &&_capsule); | ||
|
||
/// \brief Assignment operator. | ||
/// \param[in] _capsule The capsule to set values from. | ||
/// \return *this | ||
public: Capsule &operator=(const Capsule &_capsule); | ||
|
||
/// \brief Load the capsule geometry based on a element pointer. | ||
/// This is *not* the usual entry point. Typical usage of the SDF DOM is | ||
/// through the Root object. | ||
/// \param[in] _sdf The SDF Element pointer | ||
/// \return Errors, which is a vector of Error objects. Each Error includes | ||
/// an error code and message. An empty vector indicates no error. | ||
public: Errors Load(ElementPtr _sdf); | ||
|
||
/// \brief Get the capsule's radius in meters. | ||
/// \return The radius of the capsule in meters. | ||
public: double Radius() const; | ||
|
||
/// \brief Set the capsule's radius in meters. | ||
/// \param[in] _radius The radius of the capsule in meters. | ||
public: void SetRadius(const double _radius); | ||
|
||
/// \brief Get the capsule's length in meters. | ||
/// \return The length of the capsule in meters. | ||
public: double Length() const; | ||
|
||
/// \brief Set the capsule's length in meters. | ||
/// \param[in] _length The length of the capsule in meters. | ||
public: void SetLength(const double _length); | ||
|
||
/// \brief Get a pointer to the SDF element that was used during | ||
/// load. | ||
/// \return SDF element pointer. The value will be nullptr if Load has | ||
/// not been called. | ||
public: sdf::ElementPtr Element() const; | ||
|
||
/// \brief Get the Ignition Math representation of this Capsule. | ||
/// \return A const reference to an ignition::math::Sphered object. | ||
public: const ignition::math::Capsuled &Shape() const; | ||
|
||
/// \brief Get a mutable Ignition Math representation of this Capsule. | ||
/// \return A reference to an ignition::math::Capsuled object. | ||
public: ignition::math::Capsuled &Shape(); | ||
|
||
/// \brief Private data pointer. | ||
private: CapsulePrivate *dataPtr; | ||
}; | ||
} | ||
} | ||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<element name="capsule" required="0"> | ||
<description>Capsule shape</description> | ||
<element name="radius" type="double" default="0.5" required="1"> | ||
<description>Radius of the capsule</description> | ||
</element> | ||
<element name="length" type="double" default="1" required="1"> | ||
chapulina marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<description>Length of the cylindrical portion of the capsule along the z axis</description> | ||
</element> | ||
</element> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,178 @@ | ||
/* | ||
* Copyright 2020 Open Source Robotics Foundation | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
*/ | ||
#include "sdf/Capsule.hh" | ||
|
||
using namespace sdf; | ||
|
||
// Private data class | ||
class sdf::CapsulePrivate | ||
{ | ||
// A capsule with a length of 1 meter and radius if 0.5 meters. | ||
public: ignition::math::Capsuled capsule{1.0, 0.5}; | ||
|
||
/// \brief The SDF element pointer used during load. | ||
public: sdf::ElementPtr sdf; | ||
}; | ||
|
||
///////////////////////////////////////////////// | ||
Capsule::Capsule() | ||
: dataPtr(new CapsulePrivate) | ||
{ | ||
} | ||
|
||
///////////////////////////////////////////////// | ||
Capsule::~Capsule() | ||
{ | ||
delete this->dataPtr; | ||
this->dataPtr = nullptr; | ||
} | ||
|
||
////////////////////////////////////////////////// | ||
Capsule::Capsule(const Capsule &_capsule) | ||
: dataPtr(new CapsulePrivate) | ||
{ | ||
*this->dataPtr = *_capsule.dataPtr; | ||
} | ||
|
||
////////////////////////////////////////////////// | ||
Capsule::Capsule(Capsule &&_capsule) noexcept | ||
: dataPtr(std::exchange(_capsule.dataPtr, nullptr)) | ||
{ | ||
} | ||
|
||
///////////////////////////////////////////////// | ||
Capsule &Capsule::operator=(const Capsule &_capsule) | ||
{ | ||
return *this = Capsule(_capsule); | ||
} | ||
|
||
///////////////////////////////////////////////// | ||
Capsule &Capsule::operator=(Capsule &&_capsule) | ||
{ | ||
std::swap(this->dataPtr, _capsule.dataPtr); | ||
return *this; | ||
} | ||
|
||
///////////////////////////////////////////////// | ||
Errors Capsule::Load(ElementPtr _sdf) | ||
{ | ||
Errors errors; | ||
|
||
this->dataPtr->sdf = _sdf; | ||
|
||
// Check that sdf is a valid pointer | ||
if (!_sdf) | ||
{ | ||
errors.push_back({ErrorCode::ELEMENT_MISSING, | ||
"Attempting to load a capsule, but the provided SDF " | ||
"element is null."}); | ||
return errors; | ||
} | ||
|
||
// We need a capsule child element | ||
if (_sdf->GetName() != "capsule") | ||
{ | ||
errors.push_back({ErrorCode::ELEMENT_INCORRECT_TYPE, | ||
"Attempting to load a capsule geometry, but the provided SDF " | ||
"element is not a <capsule>."}); | ||
return errors; | ||
} | ||
|
||
if (_sdf->HasElement("radius")) | ||
{ | ||
std::pair<double, bool> pair = _sdf->Get<double>("radius", | ||
this->dataPtr->capsule.Radius()); | ||
|
||
if (!pair.second) | ||
{ | ||
errors.push_back({ErrorCode::ELEMENT_INVALID, | ||
"Invalid <radius> data for a <capsule> geometry. " | ||
"Using a radius of 0.5."}); | ||
chapulina marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
this->dataPtr->capsule.SetRadius(pair.first); | ||
} | ||
else | ||
{ | ||
errors.push_back({ErrorCode::ELEMENT_MISSING, | ||
"Capsule geometry is missing a <radius> child element. " | ||
"Using a radius of 0.5."}); | ||
} | ||
|
||
if (_sdf->HasElement("length")) | ||
{ | ||
std::pair<double, bool> pair = _sdf->Get<double>("length", | ||
this->dataPtr->capsule.Length()); | ||
|
||
if (!pair.second) | ||
{ | ||
errors.push_back({ErrorCode::ELEMENT_INVALID, | ||
"Invalid <length> data for a <capsule> geometry. " | ||
"Using a length of 1."}); | ||
} | ||
this->dataPtr->capsule.SetLength(pair.first); | ||
} | ||
else | ||
{ | ||
errors.push_back({ErrorCode::ELEMENT_MISSING, | ||
"Capsule geometry is missing a <length> child element. " | ||
"Using a length of 1."}); | ||
} | ||
|
||
return errors; | ||
} | ||
|
||
////////////////////////////////////////////////// | ||
double Capsule::Radius() const | ||
{ | ||
return this->dataPtr->capsule.Radius(); | ||
} | ||
|
||
////////////////////////////////////////////////// | ||
void Capsule::SetRadius(const double _radius) | ||
{ | ||
this->dataPtr->capsule.SetRadius(_radius); | ||
} | ||
|
||
////////////////////////////////////////////////// | ||
double Capsule::Length() const | ||
{ | ||
return this->dataPtr->capsule.Length(); | ||
} | ||
|
||
////////////////////////////////////////////////// | ||
void Capsule::SetLength(const double _length) | ||
{ | ||
this->dataPtr->capsule.SetLength(_length); | ||
} | ||
|
||
///////////////////////////////////////////////// | ||
sdf::ElementPtr Capsule::Element() const | ||
{ | ||
return this->dataPtr->sdf; | ||
} | ||
|
||
///////////////////////////////////////////////// | ||
const ignition::math::Capsuled &Capsule::Shape() const | ||
{ | ||
return this->dataPtr->capsule; | ||
} | ||
|
||
///////////////////////////////////////////////// | ||
ignition::math::Capsuled &Capsule::Shape() | ||
{ | ||
return this->dataPtr->capsule; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any point to having a virtual destructor? I copied it from the other classes, but would it be better without the
virtual
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to leave a comment about that but didn't because the other classes use virtual destructors. IMO, these classes are not meant to be used polymorphically (they don't have any virtual functions), so there is no need for a virtual destructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made non-virtual in 1c09156