Add python bindings for sdf::Element and sdf::Param
#1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1303 +/- ##
==========================================
- Coverage 87.64% 87.35% -0.30%
==========================================
Files 128 133 +5
Lines 16837 17133 +296
==========================================
+ Hits 14757 14966 +209
- Misses 2080 2167 +87
|
ahcorde
reviewed
Jul 28, 2023
python/src/sdf/pyElement.cc
Outdated
Comment on lines
204
to
209
| // get_attributes | ||
| // get_attribute (index) | ||
| // get_element_description_count | ||
| // get_element_description (index) | ||
| // get_element_description (string) | ||
| // has_element_description |
There was a problem hiding this comment.
Yes, I've implemented some of them. The rest, I have commented why I didn't think we need to implement them.
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
azeey
force-pushed
the
elemement_python
branch
from
8f6b894 to
784fca9
Compare
|
I've retargeted this to |
azeey
changed the title
sdf::Elementsdf::Element and sdf::Param
Voldivh
requested changes
Aug 18, 2023
Comment on lines
+64
to
+67
| .def("clone", ErrorWrappedCast<>(&Element::Clone, py::const_), | ||
| "Create a copy of this Element.") | ||
| .def("copy", ErrorWrappedCast<ElementPtr>(&Element::Copy), | ||
| "Copy values from an Element.") |
There was a problem hiding this comment.
Same comment here, is this wrapper enough for both implementations of the methods?
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Addition to #931
Summary
My intention was to add just
sdf::Element, butsdf::Paramwas needed for many of the useful APIs. Similarly,PrintConfigwas also added here.Test it
ctest -R pyElementctest -R pyParamctest -R pyPrintConfigChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.