Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gz_vendor packages #531

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Use gz_vendor packages #531

merged 5 commits into from
Apr 24, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 10, 2024

🎉 New feature

Summary

Changes Gazebo dependencies to use vendor packages (see gazebo-tooling/release-tools#1117)

Test it

Build and run tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

azeey added 2 commits April 10, 2024 18:06
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from ahcorde as a code owner April 10, 2024 23:11
Signed-off-by: Addisu Z. Taddese <[email protected]>
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are packages released and sync?

ERROR: the following rosdeps failed to install
  apt: command [apt-get install -y ros-rolling-sdformat-urdf] failed
  apt: command [apt-get install -y ros-rolling-gz-transport-vendor] failed
  apt: Failed to detect successful installation of [ros-rolling-sdformat-urdf]
  apt: Failed to detect successful installation of [ros-rolling-gz-transport-vendor]

@azeey
Copy link
Contributor Author

azeey commented Apr 11, 2024

are packages released and sync?

ERROR: the following rosdeps failed to install
  apt: command [apt-get install -y ros-rolling-sdformat-urdf] failed
  apt: command [apt-get install -y ros-rolling-gz-transport-vendor] failed
  apt: Failed to detect successful installation of [ros-rolling-sdformat-urdf]
  apt: Failed to detect successful installation of [ros-rolling-gz-transport-vendor]

Not quite yet. sdformat_urdf is waiting for ros/sdformat_urdf#28 to be merged and released.
gz-transport-vendor is released, but it's failing to build on Noble due to an issue in Noble itself (can't install python3-distutils).

@luca-della-vedova
Copy link
Member

I'm trying this PR with the vendored gz binaries in noble, was stuck at yaml-cpp yesterday but saw that is already fixed (thanks!), it seems now ros_gz_image is failing:

lucadv@noble:~/noble_ws$ colcon build --packages-select ros_gz_image
Starting >>> ros_gz_image
--- stderr: ros_gz_image                         
CMake Error at /opt/ros/rolling/opt/gz_transport_vendor/extra_cmake/lib/cmake/gz-transport/gz-transport-config.cmake:24 (add_library):
  add_library cannot create imported target "gz-transport" because another
  target with the same name already exists.
Call Stack (most recent call first):
  CMakeLists.txt:20 (find_package)


CMake Error at /opt/ros/rolling/opt/gz_msgs_vendor/extra_cmake/lib/cmake/gz-msgs/gz-msgs-config.cmake:24 (add_library):
  add_library cannot create imported target "gz-msgs" because another target
  with the same name already exists.
Call Stack (most recent call first):
  CMakeLists.txt:23 (find_package)

set(GZ_MSGS_VER ${gz-msgs9_VERSION_MAJOR})
set(GZ_TRANSPORT_VER ${gz-transport12_VERSION_MAJOR})
find_package(gz_transport_vendor REQUIRED)
find_package(gz-transport REQUIRED)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems removing this (and gz-msgs below) fixes this package's build, but not sure that is the right approach.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was in the upstream gz_msg vendor package. A similar fix to gazebo-release/gz_utils_vendor#3 has been released to all the vendor packages, but hasn't been synced to ros-testing yet. Hopefully by tomorrow.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from ahcorde April 24, 2024 05:12
@azeey
Copy link
Contributor Author

azeey commented Apr 24, 2024

@ahcorde this is ready to review. CI is green 🎉

@ahcorde ahcorde merged commit e6e6b45 into gazebosim:ros2 Apr 24, 2024
2 checks passed
@azeey azeey deleted the vendor_pkgs branch April 24, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants