-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gz_vendor packages #531
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are packages released and sync?
ERROR: the following rosdeps failed to install
apt: command [apt-get install -y ros-rolling-sdformat-urdf] failed
apt: command [apt-get install -y ros-rolling-gz-transport-vendor] failed
apt: Failed to detect successful installation of [ros-rolling-sdformat-urdf]
apt: Failed to detect successful installation of [ros-rolling-gz-transport-vendor]
Not quite yet. sdformat_urdf is waiting for ros/sdformat_urdf#28 to be merged and released. |
Signed-off-by: Addisu Z. Taddese <[email protected]>
I'm trying this PR with the vendored gz binaries in noble, was stuck at yaml-cpp yesterday but saw that is already fixed (thanks!), it seems now ros_gz_image is failing:
|
set(GZ_MSGS_VER ${gz-msgs9_VERSION_MAJOR}) | ||
set(GZ_TRANSPORT_VER ${gz-transport12_VERSION_MAJOR}) | ||
find_package(gz_transport_vendor REQUIRED) | ||
find_package(gz-transport REQUIRED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems removing this (and gz-msgs
below) fixes this package's build, but not sure that is the right approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue was in the upstream gz_msg vendor package. A similar fix to gazebo-release/gz_utils_vendor#3 has been released to all the vendor packages, but hasn't been synced to ros-testing yet. Hopefully by tomorrow.
Signed-off-by: Addisu Z. Taddese <[email protected]>
@ahcorde this is ready to review. CI is green 🎉 |
🎉 New feature
Summary
Changes Gazebo dependencies to use vendor packages (see gazebo-tooling/release-tools#1117)
Test it
Build and run tests.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.