Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set on_exit_shutdown argument for gz-sim ExecuteProcess #355

Merged

Conversation

andermi
Copy link
Contributor

@andermi andermi commented Jan 24, 2023

Signed-off-by: Michael Anderson [email protected]

🎉 New feature

Summary

Add launch argument to set gz-sim to be a required node: if argument on_exit_shutdown is True, set on_exit=Shutdown()

Test it

Make a launch file that includes gz_sim.launch.py as well as some other node. set gz_args to use --iterations 5000 and set on_exit_shutdown to True. When gz-sim exits, everything should quit.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@andermi
Copy link
Contributor Author

andermi commented Sep 20, 2023

@mjcarroll It doesn't look like this PR made it into the humble branch

@mjcarroll
Copy link
Collaborator

I will backport to iron and humble, thanks.

@mjcarroll
Copy link
Collaborator

Humble: #451
Iron: #452

mjcarroll added a commit that referenced this pull request Sep 21, 2023
mjcarroll added a commit that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants