Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures when run under colcon test #483

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Mar 18, 2024

🦟 Bug fix

Summary

colcon test wasn't working for me because the LD_LIBRARY_PATH environment variable was being overwritten.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from caguero as a code owner March 18, 2024 16:31
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.74%. Comparing base (eac2e69) to head (3bb6be3).
Report is 5 commits behind head on gz-transport13.

Additional details and impacted files
@@                Coverage Diff                 @@
##           gz-transport13     #483      +/-   ##
==================================================
+ Coverage           87.69%   87.74%   +0.04%     
==================================================
  Files                  59       59              
  Lines                5704     5710       +6     
==================================================
+ Hits                 5002     5010       +8     
+ Misses                702      700       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey merged commit ab41ee3 into gazebosim:gz-transport13 Mar 18, 2024
11 checks passed
@azeey azeey deleted the fix_colcon_test branch March 18, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants