Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no username error messages (#286) #291

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

AlexGraberTilton
Copy link
Contributor

Fixes #286

Summary

Removes the error messages that occur during some valid use cases, such as when the /etc/passwd file does not have an entry for a uid + gid due to running in docker with --user uid:gid

Signed-off-by: Alexander Graber-Tilton [email protected]

Signed-off-by: Alexander Graber-Tilton <[email protected]>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Feb 4, 2022
@AlexGraberTilton AlexGraberTilton marked this pull request as ready for review February 4, 2022 01:21
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #291 (37234b4) into ign-transport8 (c6abe3d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 37234b4 differs from pull request most recent head 3f645e8. Consider uploading reports for the commit 3f645e8 to get more accurate results

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-transport8     #291      +/-   ##
==================================================
+ Coverage           83.76%   83.82%   +0.06%     
==================================================
  Files                  51       51              
  Lines                5033     5034       +1     
==================================================
+ Hits                 4216     4220       +4     
+ Misses                817      814       -3     
Impacted Files Coverage Δ
include/ignition/transport/Discovery.hh 87.94% <ø> (+0.20%) ⬆️
src/NetUtils.cc 74.07% <ø> (+1.34%) ⬆️
src/NodeSharedPrivate.hh 100.00% <ø> (ø)
src/Discovery.cc 77.77% <100.00%> (+2.77%) ⬆️
src/NodeShared.cc 78.95% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f771ab1...3f645e8. Read the comment docs.

@nkoenig nkoenig merged commit 07ec13a into gazebosim:ign-transport8 Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants