Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 10.1.0 #272

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Prepare for 10.1.0 #272

merged 2 commits into from
Oct 18, 2021

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Oct 17, 2021

🎈 Release

Preparation for 10.1.0 release.

Comparison to 10.0.0: ignition-transport10_10.0.0...ign-transport10

Needed by <PR(s)>

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Carlos Agüero <[email protected]>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Oct 17, 2021
@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #272 (19df4f4) into ign-transport10 (8d1b2ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-transport10     #272   +/-   ##
================================================
  Coverage            89.08%   89.08%           
================================================
  Files                   51       51           
  Lines                 4772     4772           
================================================
  Hits                  4251     4251           
  Misses                 521      521           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d1b2ce...19df4f4. Read the comment docs.

chapulina
chapulina previously approved these changes Oct 17, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A release sounds good to me, but I think there are changelog entries missing, see the diff to 10.0.0. Also, given that some big changes got in, like the new CLI, I think we should bump the minor.

Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero changed the title Prepare for 10.0.1 Prepare for 10.1.0 Oct 18, 2021
@caguero
Copy link
Collaborator Author

caguero commented Oct 18, 2021

A release sounds good to me, but I think there are changelog entries missing, see the diff to 10.0.0. Also, given that some big changes got in, like the new CLI, I think we should bump the minor.

Updated, let's do a 10.1.0 then!

@caguero caguero merged commit 95bb75a into ign-transport10 Oct 18, 2021
@caguero caguero deleted the caguero_10.0.1 branch October 18, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants