Suppress focal-specific warnings #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcarroll
force-pushed
the
focal_warnings
branch
2 times, most recently
from
1e532e0 to
38d6421
Compare
Codecov Report
@@ Coverage Diff @@
## chapulina/7_to_8 #159 +/- ##
====================================================
- Coverage 83.75% 83.64% -0.12%
====================================================
Files 49 49
Lines 4832 4903 +71
====================================================
+ Hits 4047 4101 +54
- Misses 785 802 +17
Continue to review full report at Codecov.
|
chapulina
reviewed
Aug 6, 2020
Merged
mjcarroll
force-pushed
the
focal_warnings
branch
2 times, most recently
from
64a5fe0 to
d1b848a
Compare
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
focal_warnings
branch
from
d1b848a to
3c13523
Compare
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
|
The |
It happens locally for me, as well. I think because this test doesn't involve zmq, it's more likely a difference between bionic and focal library versions (possibly |
Signed-off-by: Nate Koenig <[email protected]>
Focal outputs a value of 7254000000ns. I'll try adding an #ifdef. |
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
nkoenig
approved these changes
Aug 28, 2020
I relaxed the expectation for not having to go back to this test (hopefully) after another Ubuntu release. |
caguero
approved these changes
Aug 28, 2020
nkoenig
added a commit
that referenced
this pull request
Aug 28, 2020
* Remove warnings using ZMQ 4.3.1 or greater. * Do not use ZMQ_CPP11 * Win debugging. * backport improved compiler support for std::filesystem * Close branch backport_compiler_filesystem * Restore original Playback::Start and add overload with new parameter to fix ABI * bump to 7.2.2 and update changelog * Close branch fix_abi_7 * Write to disk from a background thread in log recorder * Update Changelog * Move `dataWriterState = true` to Recorder::Implementation::DataWriterThread() thread. * Revert moving dataWriterState * Failing test with incorrect time stamps * Correctly record message reception time stamp * Reorder functions * Specify buffer size in MB rather than number of elements in the data queue * Flush any remaining data to log file when stopping the Recorder * Codecheck. The rvalue ref is used to ensure that std::vector is always moved * Version update * Added tag ignition-transport7_7.3.0~pre1 for changeset 173fae6c362d * recorder.cc: include <optional> * Add console message to indicate buffer being flushed * Add <numeric> * Close branch async_recorder * Prepare for 7.3.0 * Added tag ignition-transport7_7.3.0 for changeset 367d4f1bfcf7 * Configurable buffer sizes. * Fix typo. * Changelog. * Clarify high water mark policy. * Tweak documentation and error messages. * Close branch issue_116_transport7 * fix line lengths * Close branch codecheck7 * Update default values for the high water marks * Update buffer default values * Changelog.md edited online with Bitbucket * Close branch default_hwm * Adding connection message. * ConnectionMsg implementation. * Test * No control socket. * Preserve ABI. * Discard registrations when needed. * Tweaks. * Changelog * Fix issue #114. * Close branch discovery_extended_p2 * 7.4.0 * Move changelog entry * Close branch ign-transport7-4 * Added tag ignition-transport7_7.4.0 for changeset 083e7bf41080 * Protobuf warnings * Close branch proto_deprecations * Close branch issue_111 * Windows warnings * revert commit to release branch * Fix version for send_falgs command * Close branch ign-transport7_fix_send_flags * Backport pull request #441 * updates * Added another check * Close branch issue_118 * mv hgignore Signed-off-by: claireyywang <[email protected]> * add gitignore Signed-off-by: claireyywang <[email protected]> * [ign-transport7] Update BitBucket links (#123) * [ign-transport7] Update BitBucket links Signed-off-by: Louise Poubel <[email protected]> * changelog pull-requests * Apply suggestions from code review * Update tutorials/07_relay.md Co-authored-by: Marya Belanger <[email protected]> * [ign-transport7] Workflow updates (#132) * [ign-transport7] Workflow updates Signed-off-by: Louise Poubel <[email protected]> * Helper function to get a valid topic name (#153) Signed-off-by: Louise Poubel <[email protected]> * Remove Windows warnings (#151) Signed-off-by: Carlos Aguero <[email protected]> * Remove warnings on Homebrew (#150) Signed-off-by: Carlos Aguero <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Bump to 7.5.0 (#156) Signed-off-by: Louise Poubel <[email protected]> * Modernize actions CI (#158) Signed-off-by: Louise Poubel <[email protected]> * remove ci-bionic Signed-off-by: Louise Poubel <[email protected]> * add focal Signed-off-by: Louise Poubel <[email protected]> * msgs5 Signed-off-by: Louise Poubel <[email protected]> * Suppress focal-specific warnings (#159) * Suppress focal-specific warnings Signed-off-by: Michael Carroll <[email protected]> * Warn when lsb_release isn't present Signed-off-by: Michael Carroll <[email protected]> * Adding header guard. Signed-off-by: Carlos Agüero <[email protected]> * Include correct header file for version check Signed-off-by: Michael Carroll <[email protected]> * Added more debug output Signed-off-by: Nate Koenig <[email protected]> * Fix focal test and codecheck Signed-off-by: Nate Koenig <[email protected]> * Change endtime expectation Signed-off-by: Carlos Agüero <[email protected]> Co-authored-by: Carlos Agüero <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Carlos Aguero <[email protected]> Co-authored-by: Steve Peters <[email protected]> Co-authored-by: Steve Peters <[email protected]> Co-authored-by: Carlos Agüero <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Carlos Aguero <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Co-authored-by: claireyywang <[email protected]> Co-authored-by: Marya Belanger <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #157 and fixes #150.
Both homebrew and Ubuntu Focal package a
cppzmqversion that is reported as 4.7.0, but the deprecation warnings and available functions are different. I believe this is due in part to there not being an official 4.7.0 release.This simply detects if we are building on Ubuntu Focal and adjusts accordingly.
Signed-off-by: Michael Carroll [email protected]