Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8 ➡️ 7 #154

Merged
merged 3 commits into from
Jul 30, 2020
Merged

8 ➡️ 7 #154

merged 3 commits into from
Jul 30, 2020

Conversation

chapulina
Copy link
Contributor

Backport #151 and #150

caguero and others added 2 commits July 28, 2020 18:02
@caguero @chapulina
Remove Windows warnings (#151)
28a7944 
Signed-off-by: Carlos Aguero <[email protected]>
@caguero @chapulina
Remove warnings on Homebrew (#150)
fae09bd 
Signed-off-by: Carlos Aguero <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from caguero as a code owner July 29, 2020 01:03
@chapulina chapulina changed the title Chapulina/backport 8 to 7 8 ➡️ 7 Jul 29, 2020
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Jul 29, 2020
@codecov
Copy link

codecov bot commented Jul 29, 2020 •
edited
Loading

Codecov Report

Merging #154 into ign-transport7 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-transport7     #154   +/-   ##
===============================================
  Coverage           89.75%   89.75%           
===============================================
  Files                  49       49           
  Lines                4793     4793           
===============================================
  Hits                 4302     4302           
  Misses                491      491
Impacted Files Coverage Δ
src/Node.cc 92.32% <ø> (ø)
src/NodeShared.cc 80.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adda419...eab1e09. Read the comment docs.

@chapulina chapulina mentioned this pull request Jul 30, 2020
Merged
caguero
caguero approved these changes Jul 30, 2020
View reviewed changes
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're so close to have Ignition Transport back to green state, we only need to address a few flaky tests on Homebrew!

@chapulina chapulina merged commit ab5a663 into ign-transport7 Jul 30, 2020
@chapulina chapulina deleted the chapulina/backport_8_to_7 branch July 30, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

Assignees
No one assigned
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @caguero