Fix selection buffer crash on resize #969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🦟 Bug fix
related ign-rendering PR: gazebosim/gz-rendering#378
related issue: gazebosim/gz-rendering#362
Summary
If a window resize and mouse click happens in the same frame, the gui will crash with a backtrace pointing to the selection buffer in ign-rendering. This is more of a workaround - adding a render call ensures that the ogre resources are ready before they are used by the selection buffer (for mouse picking).
Note: we need to merge this PR before the one in ign-rendering: gazebosim/gz-rendering#378
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge