Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more specific when looking for physics plugins #965

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

chapulina
Copy link
Contributor

Summary

This came up on #617 while experimenting with different ways of loading plugins. More specifically, we were trying to use the RTLD_GLOBAL flag to load plugins, which made the plugin loader find all plugins already loaded, not only those from the current library. In that situation, it was useful to filter plugins by interface before iterating over them.

We ended up not using that flag, but I think it's a good idea to filter the plugins beforehand anyway in case a user tries to load some funky plugin.

Test it

I'd expect this change not to break any of the existing tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina requested a review from azeey August 10, 2021 23:13
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 10, 2021
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #965 (1ea86b5) into ign-gazebo3 (b7346a4) will decrease coverage by 0.01%.
The diff coverage is 20.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #965      +/-   ##
===============================================
- Coverage        77.90%   77.88%   -0.02%     
===============================================
  Files              221      221              
  Lines            12678    12681       +3     
===============================================
  Hits              9877     9877              
- Misses            2801     2804       +3     
Impacted Files Coverage Δ
src/systems/physics/Physics.cc 70.34% <20.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7346a4...1ea86b5. Read the comment docs.

@chapulina chapulina enabled auto-merge (squash) August 11, 2021 00:01
@chapulina chapulina merged commit 0f58670 into ign-gazebo3 Aug 11, 2021
@chapulina chapulina deleted the chapulina/3/physics_plugins branch August 11, 2021 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants