Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualize center of mass #903

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Visualize center of mass #903

merged 3 commits into from
Jul 6, 2021

Conversation

atharva-18
Copy link
Contributor

@atharva-18 atharva-18 commented Jul 5, 2021 •
edited
Loading

🎉 New feature

Closes #110

Summary

Adds the ability to visualize the center of mass, similar to Gazebo Classic. Related to #861.
com_visual

Test it

Test it by right-clicking on an entity and selecting View -> Center of Mass.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

atharva-18 added 3 commits July 5, 2021 16:41
@atharva-18
Add center of mass widget
fb6ecd0 
Signed-off-by: Atharva Pusalkar <[email protected]>
@atharva-18
Remove extra parent check
7a7aba6 
Signed-off-by: Atharva Pusalkar <[email protected]>
@atharva-18
Use RenderUtil::HideWireboxes
07f78bd 
Signed-off-by: Atharva Pusalkar <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 5, 2021
ahcorde
ahcorde approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahcorde ahcorde merged commit 7cc8c09 into gazebosim:main Jul 6, 2021
@chapulina chapulina mentioned this pull request Jul 6, 2021
Closed
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/google-summer-of-code-2021-new-gui-widgets-in-ignition-gazebo/1081/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@chapulina chapulina Awaiting requested review from chapulina

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees

@atharva-18 atharva-18

Labels
🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atharva-18 @osrf-triage @ahcorde