Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused headers in video_recoder plugin #834

Merged
merged 1 commit into from
May 27, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented May 26, 2021

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

Remove unused ign-gazebo headers in video_recoder plugin.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde added the enhancement New feature or request label May 26, 2021
@ahcorde ahcorde requested a review from mjcarroll May 26, 2021 21:19
@ahcorde ahcorde self-assigned this May 26, 2021
@ahcorde ahcorde requested a review from chapulina as a code owner May 26, 2021 21:19
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label May 26, 2021
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #834 (f2da2d5) into ign-gazebo3 (0cacbd5) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #834      +/-   ##
===============================================
+ Coverage        77.81%   77.86%   +0.04%     
===============================================
  Files              216      216              
  Lines            12150    12150              
===============================================
+ Hits              9454     9460       +6     
+ Misses            2696     2690       -6     
Impacted Files Coverage Δ
src/SimulationRunner.cc 94.42% <0.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cacbd5...f2da2d5. Read the comment docs.

@mjcarroll mjcarroll merged commit 3480302 into ign-gazebo3 May 27, 2021
@mjcarroll mjcarroll deleted the ahcorde/video_recorder/cleaupheaders branch May 27, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants