Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport #536 3 ⬅️ 4] Add service and GUI to configure physics parameters #812

Merged
merged 2 commits into from
May 12, 2021
Merged

[Backport #536 3 ⬅️ 4] Add service and GUI to configure physics parameters #812

merged 2 commits into from
May 12, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented May 12, 2021 •
edited by chapulina
Loading

⬅️ Backport port

Port 5 to 3

I'm backporting this commit to be able to fetch the MaxStepSize in the system plugin of ignition_ros2_control in Citadel. Refer to this conversation. With this PR merged and released we will be able to release ign_ros2_control in Foxy and Citadel.

Branch comparison: ign-gazebo3...ahcorde/backport/536

Note to maintainers: Remember to Rebase-merge

luca-della-vedova and others added 2 commits May 11, 2021 21:50
@luca-della-vedova @mrushyendra
@chapulina @ahcorde
Add service and GUI to configure physics parameters (step size and re…
f360a4b 
…al time factor) (#536)

Signed-off-by: Maganty Rushyendra <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>

Co-authored-by: mrushyendra <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
@ahcorde
Fixed backport #536
0a1ea29 
Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde added the 🏰 citadel Ignition Citadel label May 12, 2021
@ahcorde ahcorde requested a review from chapulina May 12, 2021 13:43
@ahcorde ahcorde self-assigned this May 12, 2021
@ahcorde ahcorde changed the title 3 ⬅️ 5 3 :arrow_left 5 May 12, 2021
@ahcorde ahcorde changed the title 3 :arrow_left 5 3 ⬅️ 5 May 12, 2021
@chapulina chapulina changed the title 3 ⬅️ 5 [Backport #536 3 ⬅️ 4] Add service and GUI to configure physics parameters May 12, 2021
@chapulina
Copy link
Contributor

chapulina commented May 12, 2021 •
edited
Loading

I updated the description to say "rebase" instead of merge commit, as described in the contribution guide. We don't have a template for backports because these are rare, but we should consider adding one if they become common.

chapulina
chapulina approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

@chapulina chapulina merged commit cceec4e into ign-gazebo3 May 12, 2021
@chapulina chapulina deleted the ahcorde/backport/536 branch May 12, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@ahcorde ahcorde

Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @chapulina @luca-della-vedova