-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heightmap physics (with DART) 🏔️ #661
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
This is ready for review. The heightmap behaves as expected when using the I tested the above with these branches: |
Removed from beta, this can come in a minor release. |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see any test, do you plan to add some ?
Some minor style improvements
Just for logging purposes, I've tested this PR with a source built fortress and had been able to reproduce the example and also use custom heightmaps with it. It seemed to work pretty well for me. The only down side seems to be is being stuck with ogre rather than ogre2, cross referencing gazebosim/gz-rendering#187 for more information. |
we can test this branch with the ignition-physics4 prerelease if we merge the following: gazebo-tooling/gzdev#33 |
the Ignition-physics4 prerelease homebrew bottles are built, so I restarted the macOS job |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
…tionrobotics/ign-gazebo into chapulina/5/heightmap_physics Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
🎉 New feature
Closes #237
Summary
Add heightmap support to the physics system.
Requires gazebosim/gz-physics#218
There's a resolution issue still to be solved on the physics side. It looks like only red spheres can stay on top of the heightmap 😉 🔴
Test it
Checklist
Updated migration guide (as needed)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge