Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.4.0 #625

Merged
merged 2 commits into from
Feb 11, 2021
Merged

4.4.0 #625

merged 2 commits into from
Feb 11, 2021

Conversation

adlarkin
Copy link
Contributor

Prepare for 4.4.0 release.

Comparison to 4.3.0: ignition-gazebo4_4.3.0...ign-gazebo4


Question for reviewers: (cc @iche033) since #614 doesn't require users to have the recent ign-gui4.2.0, ign-sensors4.1.0, and ign-rendering4.4.0 releases (users can keep using 16-bit thermal cameras as they have been prior to this release if they wish), we don't need to bump the dependencies on those libraries, right? Or do we need to bump those dependencies since users can't use the 8-bit option introduced in #614 without ign-gui4.2.0, ign-sensors4.1.0, and ign-rendering4.4.0?


Signed-off-by: Ashton Larkin [email protected]

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ashton Larkin <[email protected]>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Feb 11, 2021
@nkoenig
Copy link
Contributor

nkoenig commented Feb 11, 2021

We don't need to bump versions in this case. Building ign-gazebo will not be broken if the older libraries are used.

Signed-off-by: Ian Chen <[email protected]>
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #625 (3fa073f) into ign-gazebo4 (836f635) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4     #625      +/-   ##
===============================================
- Coverage        77.36%   77.31%   -0.05%     
===============================================
  Files              217      217              
  Lines            12221    12221              
===============================================
- Hits              9455     9449       -6     
- Misses            2766     2772       +6     
Impacted Files Coverage Δ
src/SimulationRunner.cc 92.88% <0.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836f635...3fa073f. Read the comment docs.

@nkoenig nkoenig merged commit d959c41 into ign-gazebo4 Feb 11, 2021
@nkoenig nkoenig deleted the adlarkin/4.4.0 branch February 11, 2021 02:42
@adlarkin adlarkin mentioned this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants