Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the selection of the visual in transform control #597

Closed
wants to merge 1 commit into from

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jan 29, 2021

I have the same issue described in this PR gazebosim/gz-rendering#221

Signed-off-by: ahcorde [email protected]

@ahcorde ahcorde added bug Something isn't working 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice labels Jan 29, 2021
@ahcorde ahcorde requested a review from iche033 January 29, 2021 14:41
@ahcorde ahcorde self-assigned this Jan 29, 2021
@ahcorde ahcorde requested a review from chapulina as a code owner January 29, 2021 14:41
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #597 (8c6de73) into ign-gazebo4 (59ea1c6) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4     #597      +/-   ##
===============================================
+ Coverage        77.24%   77.29%   +0.05%     
===============================================
  Files              213      213              
  Lines            11925    11925              
===============================================
+ Hits              9212     9218       +6     
+ Misses            2713     2707       -6     
Impacted Files Coverage Δ
src/SimulationRunner.cc 92.92% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59ea1c6...8c6de73. Read the comment docs.

@nkoenig
Copy link
Contributor

nkoenig commented Jan 29, 2021

I think this breaks selecting a transform control arrow when an object is in front of the arrow.
occlusion

@iche033
Copy link
Contributor

iche033 commented Jan 29, 2021

I think it could be a transparency change that's been done in Dome (could be in ign-rendering)

Edit

nevermind, different issue. I thought this was fixing the transform tool 's transparency problem

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 2, 2021

closing this PR the issue can be fixed in ign-rendering gazebosim/gz-rendering#221

@ahcorde ahcorde closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants