Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing IGNITION_GAZEBO_VISIBLE macros #563

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

j-rivero
Copy link
Contributor

Missing visibility from different auxiliary functions and classes

@j-rivero j-rivero requested a review from chapulina as a code owner January 15, 2021 16:52
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jan 15, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I have some questions about whether some of the changes are necessary, but they don't break anything so I think it's ok to get them in.

You can ignore homebrew CI for now, we're in an intermediate stage there.

src/Conversions.cc Show resolved Hide resolved
src/LevelManager.hh Show resolved Hide resolved
src/SdfGenerator.hh Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #563 (6b4cd17) into main (9246d67) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
+ Coverage   77.57%   77.62%   +0.05%     
==========================================
  Files         211      211              
  Lines       11582    11582              
==========================================
+ Hits         8985     8991       +6     
+ Misses       2597     2591       -6     
Impacted Files Coverage Δ
src/Conversions.cc 82.19% <ø> (ø)
include/ignition/gazebo/ServerConfig.hh 100.00% <100.00%> (ø)
src/SimulationRunner.cc 94.76% <0.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9246d67...6b4cd17. Read the comment docs.

@chapulina chapulina merged commit c809e31 into main Jan 20, 2021
@chapulina chapulina deleted the jrivero/win/missing_visible branch January 20, 2021 04:20
chapulina pushed a commit that referenced this pull request Jul 30, 2021
chapulina pushed a commit that referenced this pull request Jul 30, 2021
chapulina pushed a commit that referenced this pull request Jul 30, 2021
chapulina pushed a commit that referenced this pull request Aug 4, 2021
chapulina pushed a commit that referenced this pull request Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants