-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing IGNITION_GAZEBO_VISIBLE macros #563
Conversation
Signed-off-by: Jose Luis Rivero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I have some questions about whether some of the changes are necessary, but they don't break anything so I think it's ok to get them in.
You can ignore homebrew CI for now, we're in an intermediate stage there.
Codecov Report
@@ Coverage Diff @@
## main #563 +/- ##
==========================================
+ Coverage 77.57% 77.62% +0.05%
==========================================
Files 211 211
Lines 11582 11582
==========================================
+ Hits 8985 8991 +6
+ Misses 2597 2591 -6
Continue to review full report at Codecov.
|
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Missing visibility from different auxiliary functions and classes