Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake warnings in Noble #2397

Merged
merged 2 commits into from
May 28, 2024
Merged

Fix CMake warnings in Noble #2397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14528b0
Fix Cmake warnings
Blast545 May 7, 2024
f8c07ad
Move new argument above URL to fix issue with older cmake
azeey May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/standalone/gtest_setup/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ set(GZ_SIM_VER ${gz-sim8_VERSION_MAJOR})
include(FetchContent)
FetchContent_Declare(
googletest
DOWNLOAD_EXTRACT_TIMESTAMP TRUE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this argument above URL because older versions of CMake handled it as part of the URL and failed.https://build.osrfoundation.org/job/gz_sim-ci-pr_any-jammy-amd64/625/testReport/junit/(root)/_init_/Plugins_ExamplesBuild/

# Version 1.14. Use commit hash to prevent tag relocation
URL https://github.com/google/googletest/archive/f8d7d77c06936315286eb55f8de22cd23c188571.zip
)
set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
FetchContent_MakeAvailable(googletest)

enable_testing()
include(Dart)

# Generate tests
foreach(TEST_TARGET
Expand Down
Loading