-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows and Doxygen #1643
Fix Windows and Doxygen #1643
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1643 +/- ##
===============================================
+ Coverage 64.40% 64.43% +0.02%
===============================================
Files 320 320
Lines 25892 25892
===============================================
+ Hits 16677 16683 +6
+ Misses 9215 9209 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
|
@ros-pull-request-builder retest this please |
I wanted to take a closer look to the errors on Jammy and |
Thanks! I believe those are pre-existing. It's good to get this PR in quickly so Windows CI runs and it doesn't get more broken. |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
🦟 Bug fix
Summary
Windows
The Windows build has been broken since
This fixes in adding
IGNITION_GAZEBO_GUI_VISIBLE
. TheGZ_SIM
equivalent has already been added togz-sim7
in #1633.Doxygen
After a lot of digging, it turned out that the Doxygen crashes described in #1409 were caused by the inline namespace. The Doxygen version on Jammy (1.9.1) can't handle those well.
Warnings
Also fixed some compiler warnings that I saw on Jammy.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸