-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable MacOS flakies Citadel #1545
Disable MacOS flakies Citadel #1545
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1545 +/- ##
============================================
Coverage 77.76% 77.76%
============================================
Files 250 250
Lines 14443 14443
============================================
Hits 11231 11231
Misses 3212 3212 Continue to review full report at Codecov.
|
All tests passing, want to review and merge? :D @chapulina Besides the remaining protobuf warnings, I think Citadel is all covered to enable CI checks. I'll move further with Fortress now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Blast545 , let's give this a try for a few weeks and see if other flakies come up.
Signed-off-by: Steve Peters <[email protected]>
Backport of #1398 to Citadel and temporary disabled tests for #630 #154
Summary
Disabling flaky tests on MacOS to help with gazebo-tooling/release-tools#398
Checklist
codecheck
passed (See contributing)