-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bash completion for flags #1504
Conversation
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1504 +/- ##
============================================
Coverage 77.76% 77.76%
============================================
Files 250 250
Lines 14443 14443
============================================
Hits 11231 11231
Misses 3212 3212 Continue to review full report at Codecov.
|
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing to compile
/github/workspace/src/ign_TEST.cc: In member function 'virtual void CmdLine_GazeboHelpVsCompletionFlags_Test::TestBody()':
/github/workspace/src/ign_TEST.cc:199:28: error: 'common' has not been declared
std::string scriptPath = common::joinPaths(std::string(PROJECT_SOURCE_PATH),
^~~~~~
Signed-off-by: Mabel Zhang <[email protected]>
Oops my Docker image was broken yesterday and I couldn't test things locally. Relying on CI |
Signed-off-by: Mabel Zhang <[email protected]>
b34bbe9 adds bash completion for the |
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed some minor tweaks in 7c0f3b9. LGTM!
🎉 New feature
Part of gazebosim/gz-tools#1
Used together with gazebosim/gz-tools#87
Summary
Bash completion, installation, tests.
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.