Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accessing empty JointPosition component in lift drag plugin #1366

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Fix accessing empty JointPosition component in lift drag plugin #1366

merged 2 commits into from
Feb 25, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 25, 2022 •
edited
Loading

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Check for empty JointControl component before accessing it

Summary

Ran into a crash when the step size is not 1ms and a robot with the lift drag system is spawned into the world. The JointPosition component vector is accessed without being filled first.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033
check null comp
4516de6 
Signed-off-by: Ian Chen <[email protected]>
@iche033
better fix
a0e3b89 
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from chapulina as a code owner February 25, 2022 01:42
@iche033 iche033 requested a review from arjo129 February 25, 2022 01:43
@iche033 iche033 mentioned this pull request Feb 25, 2022
Merged
2 tasks
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 25, 2022
arjo129
arjo129 approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

@iche033 iche033 merged commit 0ae1324 into ign-gazebo6 Feb 25, 2022
@iche033 iche033 deleted the lift_drag_null_comp branch February 25, 2022 02:54
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjo129 arjo129 arjo129 approved these changes

@chapulina chapulina Awaiting requested review from chapulina

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iche033 @osrf-triage @arjo129