Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to pause/resume the trajectory follower behavior. #1347

Merged
merged 4 commits into from
Feb 18, 2022

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Feb 16, 2022

Signed-off-by: Carlos Agüero [email protected]

🎉 New feature

Summary

This patch adds the ability to pause/resume the trajectory follower behavior via an Ignition Transport message.

Test it

See the examples notes for testing.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@caguero caguero requested a review from chapulina as a code owner February 16, 2022 15:38
@caguero caguero requested a review from iche033 February 16, 2022 15:39
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 16, 2022
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me!

there were issues with github actions so I retriggered them.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #1347 (2506990) into ign-gazebo6 (1b569c9) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo6    #1347   +/-   ##
============================================
  Coverage        62.76%   62.77%           
============================================
  Files              299      299           
  Lines            24028    24028           
============================================
+ Hits             15081    15083    +2     
+ Misses            8947     8945    -2     
Impacted Files Coverage Δ
src/network/PeerInfo.cc 100.00% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b569c9...2506990. Read the comment docs.

@iche033
Copy link
Contributor

iche033 commented Feb 17, 2022

I made a change in 1a9f9f9 to fix topic names for models with spaces in their names

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 merged commit 91a79da into ign-gazebo6 Feb 18, 2022
@iche033 iche033 deleted the caguero/trajectory_follower_pause branch February 18, 2022 01:35
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants