Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks install instructions #1078

Merged
merged 9 commits into from
Nov 9, 2021
Merged

Tweaks install instructions #1078

merged 9 commits into from
Nov 9, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 1, 2021

Signed-off-by: Alejandro Hernández [email protected]

🦟 Bug fix

Summary

  • Move install instructions to a tutorial
  • added macos instructions

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@ahcorde
Tweaks install instructions
b4b9b70 
Signed-off-by: Alejandro Hernández <[email protected]>
@ahcorde ahcorde requested a review from chapulina as a code owner October 1, 2021 09:26
@ahcorde ahcorde self-assigned this Oct 1, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Oct 1, 2021
@ahcorde ahcorde mentioned this pull request Oct 1, 2021
Closed
13 tasks
@codecov
Copy link

codecov bot commented Oct 1, 2021 •
edited
Loading

Codecov Report

Merging #1078 (de41ca5) into ign-gazebo6 (ee8c3fd) will not change coverage.
The diff coverage is n/a.

❗ Current head de41ca5 differs from pull request most recent head 53e0acc. Consider uploading reports for the commit 53e0acc to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo6    #1078   +/-   ##
============================================
  Coverage        62.26%   62.26%           
============================================
  Files              257      257           
  Lines            20443    20443           
============================================
  Hits             12728    12728           
  Misses            7715     7715
Impacted Files Coverage Δ
src/SimulationRunner.cc 93.62% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee8c3fd...53e0acc. Read the comment docs.

@chapulina chapulina added the documentation Improvements or additions to documentation label Oct 5, 2021
@ahcorde ahcorde requested a review from mabelzhang as a code owner October 12, 2021 09:06
@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 12, 2021

friendly ping @chapulina

chapulina
chapulina reviewed Oct 12, 2021
View reviewed changes
@ahcorde ahcorde changed the base branch from main to ign-gazebo6 October 12, 2021 19:17
@ahcorde ahcorde force-pushed the ahcorde/improve/install_instructions branch 2 times, most recently from abf9e91 to ccb5f90 Compare October 12, 2021 19:18
@ahcorde
Added feedback
46cc3d3 
Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde force-pushed the ahcorde/improve/install_instructions branch from ccb5f90 to 46cc3d3 Compare October 12, 2021 19:19
@ahcorde ahcorde requested a review from chapulina October 12, 2021 19:20
chapulina
chapulina approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I fixed some formatting in de41ca5

@chapulina chapulina enabled auto-merge (squash) November 9, 2021 01:52
@chapulina chapulina merged commit a28b4a0 into ign-gazebo6 Nov 9, 2021
@chapulina chapulina deleted the ahcorde/improve/install_instructions branch November 9, 2021 09:13
@chapulina chapulina mentioned this pull request Nov 15, 2021
Closed
WilliamLewww pushed a commit to WilliamLewww/ign-gazebo that referenced this pull request Dec 7, 2021
@ahcorde @chapulina @WilliamLewww
Tweaks install instructions (gazebosim#1078)
b7f03ab 
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: William Lew <[email protected]>
@chapulina chapulina mentioned this pull request Jan 25, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang

Assignees

@ahcorde ahcorde

Labels
documentation Improvements or additions to documentation 🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @chapulina