Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HIDE_SYMBOLS_BY_DEFAULT + patches #403

Closed
wants to merge 4 commits into from

Conversation

j-rivero
Copy link
Contributor

🎉 New feature

Part of gazebosim/gz-cmake#392 and gazebosim/gz-cmake#166.

Summary

The PR enables the HIDE_SYMBOLS_BY_DEFAULT option and patch the failures found during the build on Linux.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@j-rivero j-rivero requested a review from iche033 as a code owner November 16, 2023 18:11
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b834d76) 72.34% compared to head (8e6ec77) 72.36%.
Report is 2 commits behind head on main.

❗ Current head 8e6ec77 differs from pull request most recent head 349ddf1. Consider uploading reports for the commit 349ddf1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
+ Coverage   72.34%   72.36%   +0.01%     
==========================================
  Files          37       37              
  Lines        5052     5055       +3     
==========================================
+ Hits         3655     3658       +3     
  Misses       1397     1397              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scpeters
Copy link
Member

it looks like fbdc887 already got pushed to main?

the changes look fine to me

@mjcarroll
Copy link
Contributor

it looks like fbdc887 already got pushed to main?

Yep, maybe an accidental push to main? Changes look fine, I'm closing this out.

@mjcarroll mjcarroll closed this Nov 21, 2023
@mjcarroll mjcarroll deleted the jrivero/missing_visibility_linux branch November 21, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants