3 ➡️ 4 #108
3 ➡️ 4 #108
Conversation
Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Fix macOS/windows tests that failed to load library (#60) * Add workflow for macos-latest * Set test env to help find plugins This fixes tests on macOS and windows that were failing to find and/or load a sensor component library. In windows CI and the macOS workflow (which runs `make test` before `make install`) tests were failing with the message "Unable to find sensor plugin path". This is fixed by setting the IGN_PLUGIN_PATH in cmake to the build folder containing the compiled plugins. In the macOS jenkins build (which runs `make test` after `make install`) tests were failing with the message "SDF sensor type does not match template type". It was difficult to track down, but it appears to be caused by a failure to properly dlopen all the shared libraries linked by the component plugins when a test finds an installed component library, rather than one from the build folder. It is fixed by setting DYLD_LIBRARY_PATH to include the location of the installed libraries. Fixes #4. * Remove redundant AddPluginPaths calls from tests They don't work on windows, so just depend on the environment variables set in cmake instead. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-sensors4 #108 +/- ##
=============================================
Coverage 76.13% 76.13%
=============================================
Files 23 23
Lines 2388 2388
=============================================
Hits 1818 1818
Misses 570 570 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Segfaults in some tests
13 - INTEGRATION_camera_plugin (SEGFAULT)
15 - INTEGRATION_depth_camera_plugin (SEGFAULT)
17 - INTEGRATION_gpu_lidar_sensor_plugin (SEGFAULT)
19 - INTEGRATION_rgbd_camera_plugin (SEGFAULT)
21 - INTEGRATION_thermal_camera_plugin (SEGFAULT)
Those tests have been failing since macOS actions were introduced in #60. The issue tracking these failures, #62, is closed. Maybe we need a new |
the failing macOS tests in our jenkins builds are tracked in #66 and #67 I'm not sure why the actions tests are seg-faulting |
actually it's probably due to lack of GPU support in the actions runners. I wouldn't block this on those macOS test failures in actions; we should probably disable those if the actions runner doesn't have GPU hardware |
➡️ Forward port
Port
ign-sensors3toign-sensors4.Branch comparison: ign-sensors4...ign-sensors3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸