Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamping for gpu_lidar with noise is causing out of range data to show in ROS2 with ros_ign_bridge. #131

Closed
patrick-neal opened this issue May 16, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@patrick-neal
Copy link

patrick-neal commented May 16, 2021

I believe the clamping in #86 might be causing no return rays to display in Rviz2.
Example of code:
https://github.com/ignitionrobotics/ign-sensors/blob/bb16d12fde391e2e9655c7e74bff85193c00f119/src/Lidar.cc#L202-L220
Comment from existing code base:
https://github.com/ignitionrobotics/ign-sensors/blob/bb16d12fde391e2e9655c7e74bff85193c00f119/src/GpuLidarSensor.cc#L186-L187
Visualization with noise
gpu_lidar_with_noise
Without noise.
gpu_lidar_without_noise

@patrick-neal patrick-neal added the bug Something isn't working label May 16, 2021
@peci1
Copy link
Contributor

peci1 commented Jun 3, 2021

This has hit us hard in our SubT solution with MARV robot!

lidar_bad

STR:

  1. LANG=C ign gazebo -v4 sensors_demo.sdf
  2. Insert model https://app.ignitionrobotics.org/OpenRobotics/fuel/models/CTU_CRAS_NORLAB_MARV_SENSOR_CONFIG_1
  3. roscore
  4. rosrun ros_ign_bridge parameter_bridge /world/lidar_sensor/model/ctu_cras_norlab_marv_sensor_config_1/link/laser/sensor/laser/scan/points@sensor_msgs/PointCloud2[ignition.msgs.PointCloudPacked
  5. open rviz and display the pointcloud

@peci1
Copy link
Contributor

peci1 commented Jun 3, 2021

Fix in #132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants