Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed integer underflow in OgreDistortionPass #994

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Apr 25, 2024

🦟 Bug fix

Summary

I've noticed the code is prone to underflow because the distorted pixel values can be negative. Practically, the underflow was not a problem because the 4e9 values coming from the underflow never matched the condition to be lower than texture width. But it is an underflow and it deserves to be fixed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@peci1 peci1 requested a review from iche033 as a code owner April 25, 2024 12:21
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 25, 2024
Signed-off-by: Martin Pecka <[email protected]>
@iche033 iche033 merged commit 9bc0b46 into gazebosim:ign-rendering6 Apr 25, 2024
8 of 10 checks passed
iche033 pushed a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants