Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simple_demo on Windows #987

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Apr 13, 2024

🦟 Bug fix

Fixes compilation of simple_demo on Windows.

Summary

I took the missing Windows logic from wide_angle_camera example. Differently from #986, after this fix simple_demo works fine on Windows both with ogre and ogre2 plugins.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Silvio Traversaro <[email protected]>
@traversaro traversaro requested a review from iche033 as a code owner April 13, 2024 14:59
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Apr 13, 2024
@ahcorde ahcorde enabled auto-merge (squash) April 15, 2024 07:21
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh thanks for the fix, looks likes we'll need to do this for other examples in gz-rendering

@ahcorde ahcorde merged commit ef05935 into gazebosim:main Apr 15, 2024
5 of 6 checks passed
@traversaro
Copy link
Contributor Author

oh thanks for the fix, looks likes we'll need to do this for other examples in gz-rendering

I realized only later that many of this fixes were actually contained also in #291 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants