-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip particle passes in Ogre2DepthCamera if there are no particles in the scene #971
Conversation
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linters
/github/workspace/ogre2/src/Ogre2DepthCamera.cc:1067: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/ogre2/src/Ogre2DepthCamera.cc:1093: Lines should be <= 80 characters long [whitespace/line_length] [2]
Signed-off-by: Ian Chen <[email protected]>
fixed linter errors and tests in e4ac886 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gz-rendering8 #971 +/- ##
==================================================
+ Coverage 0 75.59% +75.59%
==================================================
Files 0 177 +177
Lines 0 16934 +16934
==================================================
+ Hits 0 12802 +12802
- Misses 0 4132 +4132 ☔ View full report in Codecov by Sentry. |
… the scene (#971) Signed-off-by: Ian Chen <[email protected]>
🦟 Bug fix
Summary
Minor performance optimization to ogre2's depth camera implementation. Similar to #965, I used execution mask to skip rendering the particle passes if there are no particles in the scene. This yields a small speed up, see the time it takes to do 1 render operation (for a 320x240 depth camera) before and after the changes in this PR:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.