Backport ogre2 lidar performance improvement changes #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
|
I thought we used "Rebase and merge" for backports. |
ahcorde
approved these changes
Jan 17, 2024
answered in a separate chat discussion: "The changes couldn't be directly backported as the implementation were too different so I created a new commit" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Backport
backport of #955
Note that from
gz-rendering7onwards, the Ogre2GpuRays' compositor was ported to a script (as seen in #955) from C++. So the changes are not directly backported. Instead, this PR sets the ogre2 compositor parameters via C++ forign-rendering6(fortress).Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)