Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix float comparison warnings in test #929

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix float comparison warnings in test #929

merged 1 commit into from
Oct 3, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 3, 2023

🦟 Bug fix

Summary

Fix compile warnings:

warning: comparing floating-point with ‘==’ or ‘!=’ is unsafe [-Wfloat-equal]

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Oct 3, 2023
@iche033 iche033 mentioned this pull request Oct 3, 2023
Merged
8 tasks
@iche033 iche033 merged commit 4cf24f7 into ign-rendering6 Oct 3, 2023
9 checks passed
@iche033 iche033 deleted the fix_warnings branch October 3, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iche033 @ahcorde