Fix calling GpuRays::Destroy more than once #860
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Fixes gz-sensors'
INTEGRATION_dvl
test with ogre on HarmonicThe test has been failing (crashing) on homebrew CI which runs test with
ogre
. I was able to reproduce the crash and found that the issue is due to the ogre node being destroyed twice on the rendering side. Added a check to make sure we return from theDestroy
function if camera is null (indicates resources have been removed already). The same check exists in the ogre2 version.To reproduce the test failure in Harmonic workspace:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.