-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OGRE 2 with VirtualGL #794
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #794 +/- ##
==================================================
+ Coverage 77.81% 77.83% +0.01%
==================================================
Files 146 146
Lines 13412 13416 +4
==================================================
+ Hits 10437 10442 +5
+ Misses 2975 2974 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The probing process OGRE uses might change the current GLX context, e.g. when used with VirtualGL. Signed-off-by: Martin Pecka <[email protected]>
a9634c6
to
2f18450
Compare
I've tested this PR with all the combinations I could test - (Gazebo server with rendering sensors | Gazebo client) X (Gazebo rendering via GLX | Gazebo rendering via EGL ( |
Thanks for the fix! I think something was went wrong on the homebrew build. Retriggered a new one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
builds looks good
🦟 Bug fix
Fixes #526 and maybe gazebosim/gz-sim#1746 .
Summary
Restore GLX context after loading the OGRE plugin. It is possible the loading process changes the current GLX context.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.