Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message to see troubleshooting page when render engine fails to initialize #793

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Dec 20, 2022

🦟 Bug fix

Summary

Instructs the user to visit https://gazebosim.org/docs/fortress/troubleshooting when render engine fails to initialize. There is already some information on the page about issues creating the render window. I plan to add a little more info that page.

We'll need to update the url when merging forward.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Dec 20, 2022
Signed-off-by: Ian Chen <[email protected]>
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #793 (d48fb5c) into ign-rendering6 (b3df123) will decrease coverage by 0.03%.
The diff coverage is 70.00%.

@@                Coverage Diff                 @@
##           ign-rendering6     #793      +/-   ##
==================================================
- Coverage           77.85%   77.82%   -0.04%     
==================================================
  Files                 146      146              
  Lines               13404    13412       +8     
==================================================
+ Hits                10436    10438       +2     
- Misses               2968     2974       +6     
Impacted Files Coverage Δ
ogre2/src/Ogre2RenderEngine.cc 78.29% <0.00%> (-0.53%) ⬇️
ogre2/src/Ogre2Camera.cc 87.86% <25.00%> (-1.49%) ⬇️
ogre2/src/Ogre2DepthCamera.cc 88.37% <100.00%> (ø)
ogre2/src/Ogre2GpuRays.cc 95.52% <100.00%> (+<0.01%) ⬆️
ogre2/src/Ogre2RenderTarget.cc 86.33% <100.00%> (ø)
ogre2/src/Ogre2SelectionBuffer.cc 93.06% <100.00%> (ø)
ogre2/src/Ogre2ThermalCamera.cc 88.60% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants