Add odd grid offset and fix vertical bars #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 23, 2020 13:23
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
iche033
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a better and more intuitive approach to odd horizontal and vertical cell count. Previously, odd vertical cell count would change the grid to be about the origin, and odd horizontal cell count would readjust the grid as well. This PR will simply append a row and column to the grid in cases of odd horizontal cell count instead of moving the grid over. Similarly, an odd vertical cell count will add a grid layer above the current grid rather than moving the grid to center itself around the origin. I also found a bug in the vertical bar generation of the 3D grids and fixed it in this PR.
Before:
After
Before:
After:
Fixes ign-rendering#70
Signed-off-by: John Shepherd [email protected]