Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Marker test #673

Merged
merged 7 commits into from
Jul 25, 2022
Merged

Update Marker test #673

merged 7 commits into from
Jul 25, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 15, 2022

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

Added more tests to increase code coverage

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 marked this pull request as draft July 15, 2022 01:04
@iche033 iche033 added tests Broken or missing tests / testing infra QA Quality assurance. 🏯 fortress Ignition Fortress labels Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #673 (6fce8d1) into ign-rendering6 (7e6e45c) will increase coverage by 0.77%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           ign-rendering6     #673      +/-   ##
==================================================
+ Coverage           53.81%   54.58%   +0.77%     
==================================================
  Files                 202      202              
  Lines               21106    21106              
==================================================
+ Hits                11358    11521     +163     
+ Misses               9748     9585     -163     
Impacted Files Coverage Δ
include/ignition/rendering/base/BaseGizmoVisual.hh 88.02% <0.00%> (+0.49%) ⬆️
ogre2/src/Ogre2Capsule.cc 66.10% <0.00%> (+5.08%) ⬆️
src/TransformController.cc 90.18% <0.00%> (+31.59%) ⬆️
ogre2/src/Ogre2Marker.cc 74.07% <0.00%> (+33.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9b76f...6fce8d1. Read the comment docs.

src/Marker_TEST.cc Outdated Show resolved Hide resolved
src/Marker_TEST.cc Show resolved Hide resolved
@iche033 iche033 marked this pull request as ready for review July 21, 2022 23:03
@chapulina chapulina enabled auto-merge (squash) July 23, 2022 05:07
@chapulina chapulina added the bug Something isn't working label Jul 23, 2022
@chapulina chapulina merged commit 626b100 into ign-rendering6 Jul 25, 2022
@chapulina chapulina deleted the marker_test branch July 25, 2022 19:28
@iche033 iche033 mentioned this pull request Oct 12, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏯 fortress Ignition Fortress QA Quality assurance. tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants