Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for zero retro value #527

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Add test case for zero retro value #527

merged 1 commit into from
Jan 5, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jan 5, 2022

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

A follow up to #522. Retro values for objects that do not have anything set should now return zero. Added a check and remove todo comment.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 5, 2022
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #527 (9ac202f) into ign-rendering6 (1505138) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering6     #527   +/-   ##
===============================================
  Coverage           54.40%   54.40%           
===============================================
  Files                 198      198           
  Lines               20084    20084           
===============================================
  Hits                10926    10926           
  Misses               9158     9158           
Impacted Files Coverage Δ
ogre2/src/Ogre2GpuRays.cc 95.48% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1505138...9ac202f. Read the comment docs.

@iche033 iche033 merged commit d47c058 into ign-rendering6 Jan 5, 2022
@iche033 iche033 deleted the retro_test branch January 5, 2022 02:28
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants